perf(core): [SDK Overhead Reduction 6] Reduce JsonWriter stack allocation#5591
Draft
adinauer wants to merge 1 commit into
Draft
perf(core): [SDK Overhead Reduction 6] Reduce JsonWriter stack allocation#5591adinauer wants to merge 1 commit into
adinauer wants to merge 1 commit into
Conversation
Shrink the vendored JsonWriter nesting stack from 32 entries to 8 entries. The stack still grows on demand for deeply nested payloads, while common SDK serialization avoids the larger initial array allocation. Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Jun 22, 2026
Merged
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
This was referenced Jun 23, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (SDK Overhead Reduction)
📜 Description
Reduce the initial nesting stack in the vendored
JsonWriterfromint[32]toint[8].The stack still grows on demand through the existing
push()logic when serializing deeply nested payloads.💡 Motivation and Context
JsonWriteris created for envelope headers, item headers, and serialized payloads. Sentry SDK JSON is shallow in normal use, so the upstream GSON default stack size is larger than needed for the common path.Starting with a smaller stack reduces per-writer allocation while preserving support for deeper JSON structures.
💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.vendor.gson.stream.JsonWriterTest./gradlew spotlessApply apiDump📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog